Merged
Conversation
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change addresses a critical backwards compatibility issue where the package unnecessarily required Python 3.12+ as highlighted in issue #13, blocking adoption for users on Python 3.10/3.11 environments. After comprehensive code analysis, no Python 3.11+ or 3.12+ specific features were found in the codebase, making the stricter version requirement unjustified.
The change also includes a major refactoring of the core class from
AnalyzerCoretoCodeanalyzerto provide better library naming consistency and enable direct library imports.How Has This Been Tested?
ast.unparse(), built-in generics, type hints) are compatible with Python 3.10from codeanalyzer import CodeanalyzerBreaking Changes
AnalyzerCoreclass toCodeanalyzer- users importing the class directly will need to update their imports>=3.12to==3.10- this actually improves compatibility but is technically a breaking change in version specificationTypes of changes
Checklist
Additional context
Key Changes:
AnalyzerCore→Codeanalyzerfor better naming consistencyfrom codeanalyzer import Codeanalyzer>=3.12to==3.10for backwards compatibilityImpact:
Files Changed:
BUG_REPORT_PYTHON_DOWNGRADE.md- Created comprehensive bug analysisThis release significantly improves the package's accessibility while maintaining all existing functionality.